fix(concurrency): skip Octane::concurrently when no tasks to prevent … #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false TaskTimeoutException This patch prevents unnecessary calls to Octane::concurrently() when the $tasks array is empty. Without this guard, Octane sometimes triggers a misleading TaskTimeoutException: Task timed out after 30000 milliseconds — even when there are no actual tasks to run. This happens because Octane initializes the task pool regardless of input size, and an empty collection causes its internal wait cycle to expire. By returning an empty array early, we: avoid wasting resources initializing a no-op concurrent pool; prevent false timeouts and misleading error logs; improve the reliability of concurrency handling for cases where dynamic task lists may be empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents unnecessary calls to Octane::concurrently() when the $tasks array is empty.
Without this guard, Octane sometimes triggers a misleading
TaskTimeoutException: Task timed out after 30000 milliseconds — even when there are no actual tasks to run.
This happens because Octane initializes the task pool regardless of input size, and an empty collection causes its internal wait cycle to expire.
By returning an empty array early, we:
avoid wasting resources initializing a no-op concurrent pool;
prevent false timeouts and misleading error logs;
improve the reliability of concurrency handling for cases where dynamic task lists may be empty.